search

kimchi-project / kimchi

An HTML5 management interface for KVM guests
https://github.com/kimchi-project/kimchi/releases/latest
Other
3.1k stars 364 forks source link

Spice web client addon #1225

Closed pgurenko closed 5 years ago

pgurenko commented 6 years ago

Hi,

This is the add-on integration of the spice-web-client (https://github.com/eyeos/spice-web-client), created this pull in place of the previous one.

@alinefm need your input on how best to let client know which spice is up on the server (spice-web-client or spice-html5)

marclaporte commented 5 years ago

@pgurenko

Are you confident this is a good direction to go in?

There has been no commits in 2 years: https://github.com/eyeos/spice-web-client/commits/master

And http://eyeos.com/ is not loading

pgurenko commented 5 years ago

Well, it just worked for me (windows clients with qxl) while spice-html5 did not. At the current stage I guess both of them are not really good.

alinefm commented 5 years ago

@pgurenko could you rebase this PR on latest master branch?

pgurenko commented 5 years ago

@alinefm done!

alinefm commented 5 years ago

@pgurenko Thank you! I did a last small comment about this patch.

pgurenko commented 5 years ago

@alinefm at last got time to fix and test the solution. The good news - it works: Right now, to switch to eyeOS web client, use --with-spice-web-client flag when running autogen.sh:

 ./autogen.sh --system --with-spice-web-client

After deployment, eyeOS web client will be hooked up.

The bad news: Looks like QXL drivers moved forward again and now image is flipped even with eyeOS web client. Looking at the more-up-to-date forks (flexVDI one is quite promising) to try to fix this.

pgurenko commented 5 years ago

@alinefm ported flexVDI fixes and now it all works!