search

kimchi-project / kimchi

An HTML5 management interface for KVM guests
https://github.com/kimchi-project/kimchi/releases/latest
Other
3.1k stars 364 forks source link

Add a configuration option for disabling taking a screenshot #1231

Closed ss23 closed 5 years ago

ss23 commented 6 years ago

On my system with 23 running VMs, this takes 1.5 minutes to load /plugins/kimchi/vm beforehand, and 2 seconds when disabled.

Resolves #1130

ss23 commented 6 years ago

Not sure what has gone wrong here, but 7a9dfa3eef332a9b9beeb7bb1b925f68bcc8a51a is the only commit that is relevant.

marclaporte commented 5 years ago

hmmm

How about doing it on demand? Ex.: when you click or mouse-over.

Also, can you make a clean pull request?

Thanks

alinefm commented 5 years ago

@ss23 Thank you for this patch! Could you, please, rebase it on top of master branch?

ss23 commented 5 years ago

@alinefm Rebased