search

kimchi-project / kimchi

An HTML5 management interface for KVM guests
https://github.com/kimchi-project/kimchi/releases/latest
Other
3.1k stars 364 forks source link

Guest add volume size missmatch #1340

Open morecool opened 3 years ago

morecool commented 3 years ago

https://github.com/kimchi-project/kimchi/blob/36ed74be5d2016848ea6e453d7fb990d3d7fe3cd/ui/js/src/kimchi.guest_storage_add.main.js#L496

                var sizeInMB = parseInt(settings['capacity']) * 1024;
                settings['capacity'] = sizeInMB;

that line means sizeInKB... just multiple 1024 again..

                var sizeInMB = parseInt(settings['capacity']) * 1024 * 1024;
                settings['capacity'] = sizeInMB;

and WebUI is displays by GB... so 

                var sizeInMB = parseInt(settings['capacity']) * 1024 * 1024;
                var sizeInGB = sizeInMB * 1024;
                settings['capacity'] = sizeInGB;

regards.