Loosen Debian Control-file dependencies

[mfonville]

Currently Kimchi 'depends' within the debian control file on certain dependencies that are too tight and can break setups. For example the 'firewalld' dependency can break current server installations by enforcing such an application without the user/administrator being notified about the necessity of setting up specific firewall rules for this new automatically pulled-in application.

I would propose to change such dependencies to 'recommends' for some of the 'utilities' that are not necessary to execute kimchi and a 'suggests' for a package like 'firewalld' that can unintentionally break your system.

[mfonville]

A patch for having firewalld as suggests possibility:

diff --git a/contrib/DEBIAN/control.in b/contrib/DEBIAN/control.in
index aac1a24..707bf3e 100644
--- a/contrib/DEBIAN/control.in
+++ b/contrib/DEBIAN/control.in
@@ -22,8 +22,8 @@ Depends: python-cherrypy3 (>= 3.2.0),
          python-ipaddr,
          python-lxml,
          open-iscsi,
-         firewalld,
          nginx
+Suggests: firewalld
 Build-Depends: libxslt,
                python-libxml2

[alinefm]

@mfonville does spec file have a similar way to display suggested packages? As Kimchi is supported in different distros we should make sure it behaves the same way among them.

You can also send the patchs to Kimchi mailing list for review (they will always welcome) More information at https://github.com/kimchi-project/kimchi/wiki/How-to-Contribute

[mfonville]

For spec files it also possible to use 'suggests', see: https://wiki.mageia.org/en/Packaging_for_beginners

[alinefm]

Great! @mfonville do you want to send a patch about it to Kimchi ML?

[mfonville]

I will, I will also post the patch here.

Though I have to notice that I can't check the correctness on Fedora, since I don't have it, and the firewalld dependency is not even mentioned at all in the Suse spec-file.

diff --git a/contrib/DEBIAN/control.in b/contrib/DEBIAN/control.in
index 3754fa2..9c2dcdb 100644
--- a/contrib/DEBIAN/control.in
+++ b/contrib/DEBIAN/control.in
@@ -22,10 +22,10 @@ Depends: python-cherrypy3 (>= 3.2.0),
          python-ipaddr,
          python-lxml,
          open-iscsi,
-         firewalld,
          nginx,
          python-guestfs,
          libguestfs-tools
+Suggests: firewalld
 Build-Depends: libxslt,
                python-libxml2
 Maintainer: Aline Manera <alinefm@br.ibm.com>
diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in
index 5766784..af716d5 100644
--- a/contrib/kimchi.spec.fedora.in
+++ b/contrib/kimchi.spec.fedora.in
@@ -48,7 +48,7 @@ BuildRequires:    python-unittest2

 %if 0%{?with_systemd}
 Requires:      systemd
-Requires:      firewalld
+Suggests:      firewalld
 Requires(post): systemd
 Requires(preun): systemd
 Requires(postun): systemd

[mfonville]

My patch has been rejected on the mailinglist because I am not a member on the list.

[alinefm]

@mfonville You need to subscribe to Kimchi ML prior to send patches. kimchi-devel: http://lists.ovirt.org/mailman/listinfo/kimchi-devel kimchi-users: http://lists.ovirt.org/mailman/listinfo/kimchi-users

[mfonville]

I'd rather not, since I wont' really have that much time to get involved with the project; could you then maybe forward the patch for me to the mailinglist?

[alinefm]

Fixed by 5ab71df7622ecd8ac0c6e271b3ce2d4cbc403706