search

kimchi-project / kimchi

An HTML5 management interface for KVM guests
https://github.com/kimchi-project/kimchi/releases/latest
Other
3.1k stars 364 forks source link

Kimchi: [New UI] Guest edit window buttons does not follow the standard #774

Open Truja opened 8 years ago

Truja commented 8 years ago

If you edit the Guest and go over the tabs, you will notice that buttons like "Storage: Detach " , "Storage: Substitute" , "Interface: Edit", "Interface: Remove" does not look like other buttons.

samhenri commented 8 years ago

The buttons are following the design specs. The only difference from the mockups are the "Add" button in Storages (right now it opens a modal window, this will be changed in the next release) and the buttons labels and width:

Mockup: Mockup by Susan

Current: Current

Editing - Mockup: Mockup by Susan

Editing - Current: Current

The same goes for Edit Interface.

Truja commented 8 years ago

OK, I understand that it was defined like this in the UI Specification and you did as planned (excellent). However, I got a question: Can you give me a (good) reason on why should the buttons and placements be different in all screens ? What are the advantages for the end user and implementation ?

Just to be clear, I am not a UI expert, I am trying to think as final user and how to improve user experience and code reuse/maintenance. Also I want to understand if there were mistakes in the design (I did not review it before).