search

kimerdle / perl-on-netbeans

Automatically exported from code.google.com/p/perl-on-netbeans
0 stars 0 forks source link

perlcritic command line argument generation issue #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi Sudeep,

thanks for your great job.
I encountered a little problem while testing perl-on-netbeans and using perl 
critic feature.

Steps to reproduce the problem
1. launch perl-on-netbeans app
2. change value of option 'Tools > Options > Perl On NetBeans > Criticism 
Severity' to 5 and click 'Ok'
3. in the Projects panel select a perl file, right-click and select 
'Perl::Critic Code Analysis'

Expected : perl critic report
Actual result : Unknown option: severity5

Cause : missing space between '--severity' command line argument generated and 
its level '5' -> '--severity5' should be '--severity 5' instead

tested on :
ubuntu 12.04.2 LTS desktop version x64
Java(TM) SE Runtime Environment (build 1.7.0_25-b15)

Best Regards

Eric

Original issue reported on code.google.com by d...@eviweb.fr on 20 Jun 2013 at 11:05

GoogleCodeExporter commented 9 years ago 
Hi Eric,

Thanks for trying out the IDE and your efforts in logging this issue. Currently 
I see that this is not replicated on my Windows machine and hence looks like a 
platform specific issue to me. But of course, this will be addressed.

May I request for a screenshot of the issue. This way it becomes easy for me. 
Thanks again for your efforts.

Original comment by sudeepha...@gmail.com on 20 Jun 2013 at 2:31

GoogleCodeExporter commented 9 years ago 
Hi Sudeep,

thanks for your reply.
Here are some screenshots of my configuration, the action performed and the 
result obtained.
I can confirm this is not a platform specific issue. I just tested it on a 
windows 7 environment, with strawberry perl last stable version installed.

As I saw that a version of perlcritic utility is present in the application 
distribution, maybe the problem is due to the use of the external tool 
specified in the option panel.
But I cannot verify this assumption as I did not find relevant classes in the 
source code available from the subversion repository.
I think this issue is very trivial, a simple space should be missing somewhere 
in a string concatenation.

I hope these precisions will help you, feel free to contact me back in case of 
needs.
If I can access the source code, I can investigate by my own if that could 
help. Is it available somewhere ?

Best regards

Eric

Original comment by d...@eviweb.fr on 20 Jun 2013 at 9:00

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi Eric,

Thanks for the detailed description of the issue. This would be addressed by 23 
Jun 2013 when I have another scheduled build.

For the code repository, the latest version of the code is on my local SVN 
server. Will try to get it online and share the access in a couple of days' 
time.

Thanks again :)

Original comment by sudeepha...@gmail.com on 21 Jun 2013 at 5:18

GoogleCodeExporter commented 9 years ago 
You're welcome ;)

Really thanks for your job, it is very interesting and useful as well.

Eric

Original comment by d...@eviweb.fr on 21 Jun 2013 at 6:52

GoogleCodeExporter commented 9 years ago 
New version will be uploaded in a few minutes.

Original comment by sudeepha...@gmail.com on 23 Jun 2013 at 6:42

GoogleCodeExporter commented 9 years ago 
Hi Eric,

Please share your feedback with the latest uploaded version.

Original comment by sudeepha...@gmail.com on 24 Jun 2013 at 4:24

GoogleCodeExporter commented 9 years ago 
Hi Sudeep,

I just ran the last revision and on both environment the issue is fixed.
Thanks for taking care of it ;)

Are there other improvements ?

Eric

Original comment by d...@eviweb.fr on 24 Jun 2013 at 9:09

GoogleCodeExporter commented 9 years ago 
This was just a fix for the reported issue.  I kind of have a bias to add
new features only in main versions. :-)

Original comment by sudeepha...@gmail.com on 24 Jun 2013 at 9:56

GoogleCodeExporter commented 9 years ago

Original comment by sudeepha...@gmail.com on 24 Jun 2013 at 12:14

GoogleCodeExporter commented 9 years ago 
Hi Sudeep,

I don't find any information reflecting the revision number neither in the 
"Help > About" menu nor in the title bar, maybe should it be mentioned 
somewhere to prevent confusion.

Maybe I missed something, but as I didn't find any documentation on how to 
upgrade the application, I simply unzipped the archive on the installed files, 
forgetting configuration tweaks that I had made...
It would be great to have a description on what to update and how to do it.

Thanks

Eric

Original comment by d...@eviweb.fr on 24 Jun 2013 at 2:50

GoogleCodeExporter commented 9 years ago 
Hi Eric,

Point noted. This quick fix was the same IDE with just the issue resolved. It 
did not derive as a separate patch that can be upgraded individually.

Regret the inconvenience. This would be taken care of in the upcoming versions.

Original comment by sudeepha...@gmail.com on 24 Jun 2013 at 3:08

GoogleCodeExporter commented 9 years ago 
I guessed this fix was not a complete rewrite but in doubt I chose the 
"bulldozer" way... in my full conscience ;)
So don't worry about any inconvenience, this is definitely not your fault.

Eric

Original comment by d...@eviweb.fr on 24 Jun 2013 at 3:47

GoogleCodeExporter commented 9 years ago 
:)

Original comment by sudeepha...@gmail.com on 24 Jun 2013 at 5:18