Add more string types - Githubissues

kimgr / asn1ate

A Python library for translating ASN.1 into other forms.

Other

69 stars 41 forks source link

Add more string types #28

Closed viraptor closed 8 years ago

viraptor commented 8 years ago

Fixes issue #27

kimgr commented 8 years ago

Looks great! If there are no more string types, could you also remove the trailing TODO in the test file?

Many thanks!

kimgr commented 8 years ago

Actually, let me clean that up myself. Thanks for your patch!

kimgr commented 8 years ago

Oops, it looks like this PR only contained half of the change (only the codegen change + tests, not the parser changes.) Can you rebase and post a new PR? Thanks!

viraptor commented 8 years ago

That confused me too at first :) The parser already contained all the needed keywords and had them in the grammar.

kimgr commented 8 years ago

Oh, I see that now. Never mind me :-)