search

kimikage / ProfileSVG.jl

Write flame graphs to SVG format and explore them interactively in Jupyter, Pluto, etc.
MIT License
53 stars 7 forks source link

Improve mouse wheel event handler #18

Closed kimikage closed 4 years ago

kimikage commented 4 years ago

This uses the standard WheelEvent API instead of legacy APIs. https://caniuse.com/#feat=mdn-api_wheelevent_deltay

This also explicitly calls stopPropagation(). I don't know the need for it, but it might solve the issue #5.

However, this PR does not change the essential behavior. I will improve the zoom UI in v0.2 series.

codecov-io commented 4 years ago

Codecov Report

Merging #18 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #18   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files           2        2           
  Lines          82       82           
=======================================
  Hits           72       72           
  Misses         10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 19f62f6...8f136b7. Read the comment docs.