search

kimikage / ProfileSVG.jl

Write flame graphs to SVG format and explore them interactively in Jupyter, Pluto, etc.
MIT License
52 stars 7 forks source link

Add support for `width`, `height` and `font` options #34

Closed kimikage closed 4 years ago

kimikage commented 4 years ago

This reduces the hard-coded numbers and makes the layout more flexible. This also adds new API set_default() and init().

preview: https://kimikage.github.io/ProfileSVG.jl/previews/PR34/

Fixes #8, Fixes #32, Fixes #33

codecov-commenter commented 4 years ago

Codecov Report

Merging #34 into master will increase coverage by 10.86%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           master       #34       +/-   ##
============================================
+ Coverage   89.13%   100.00%   +10.86%     
============================================
  Files           2         2               
  Lines          92       115       +23     
============================================
+ Hits           82       115       +33     
+ Misses         10         0       -10
Impacted Files Coverage Δ
src/ProfileSVG.jl 100.00% <100.00%> (+17.54%) :arrow_up:
src/svgwriter.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6df3843...73a5962. Read the comment docs.

kimikage commented 4 years ago

Is it better to use set_options instead of set_default? Also, would it be beneficial to add set_default_size? cf https://github.com/davidanthoff/ProfileVega.jl/blob/v1.1.0/src/options.jl

These have to be decided before the release of v0.2, but not right now.