search

kimikage / ProfileSVG.jl

Write flame graphs to SVG format and explore them interactively in Jupyter, Pluto, etc.
MIT License
53 stars 7 forks source link

Add support for limiting graph size #39

Closed kimikage closed 4 years ago

kimikage commented 4 years ago

This adds maxdepth and maxframes options. This changes the field types of the FGConfig to concrete types in principle.

preview: https://kimikage.github.io/ProfileSVG.jl/previews/PR39/

Fixes #17

codecov-commenter commented 4 years ago

Codecov Report

Merging #39 into master will increase coverage by 10.98%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           master       #39       +/-   ##
============================================
+ Coverage   89.01%   100.00%   +10.98%     
============================================
  Files           2         2               
  Lines          91       126       +35     
============================================
+ Hits           81       126       +45     
+ Misses         10         0       -10
Impacted Files Coverage Δ
src/ProfileSVG.jl 100.00% <100.00%> (+17.54%) :arrow_up:
src/svgwriter.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b10d6e...c0930c3. Read the comment docs.

kimikage commented 4 years ago

The names (cf. https://github.com/kimikage/ProfileSVG.jl/issues/17#issuecomment-640069394) and default values of the options remain a matter of debate.

However, the commonly reasonable default values are not known unless we actually use it. Tweaks will be done after the release of v0.2.0.