kimikage / ProfileSVG.jl

Write flame graphs to SVG format and explore them interactively in Jupyter, Pluto, etc.

MIT License

53 stars 7 forks source link

Use system-ui font by default #63

Closed fonsp closed 7 months ago

fonsp commented 2 years ago

Before

Schermafbeelding 2022-01-05 om 12 04 44

After

Schermafbeelding 2022-01-05 om 12 05 12

Info

system-ui is the font that your browser uses to render the 'chrome' UI: toolbars and menus. It is the most 'neutral' font for UI. inherit would use the default font by the display system, which is likely a font designed for paragraphs of text, not UI.

https://drafts.csswg.org/css-fonts-4/#system-ui-def

fonsp commented 2 years ago

bump

kimikage commented 7 months ago

Sorry for the very late reply. I think this PR is reasonable. However, I don't think "inherit" is a bad choice. Setting "system-ui" disables font specification on the container side.