search

kimlimjustin / xplorer

Xplorer, a customizable, modern file manager
https://xplorer.space/
Apache License 2.0
4.04k stars 290 forks source link

chore(build)!: fix build on non-windows machines #302

Open curtisy1 opened 3 months ago

curtisy1 commented 3 months ago

Motivation

Working on Linux, I had to do a few things to get this branch to build successfully.

  1. I noticed there was a mismatch between tauri package versions in yarn.lock and the package.json.
  2. live-server's latest version also had CRLF endings, which yarn doesn't like at all, causing build failures
  3. python on Linux is the legacy python2, which is no longer installed by default
  4. For some reason, copyfiles.py did not copy files for me. This might be due to the change in 3.

Changes

  1. Specify existing tauri package versions in package.json
  2. Pin live-server to 1.2.1 to avoid breaking systems with LF
  3. I wrote a quick and dirty shell script, that uses python on windows and python3 on other systems. I wasn't able to test this on windows, so please give it a try before merging! If it doesn't work, I think leaving python out of the equation and using the old JS copyfiles or the webpack copy files plugin would be a better approach.
  4. I adjusted the paths, filtered out .tsx files and created directories if they didn't exist yet

Additional comments

I marked this as breaking because it could potentially break Windows system builds

vercel[bot] commented 3 months ago

@curtisy1 is attempting to deploy a commit to the Justin Maximillian Kimlim's projects Team on Vercel.

A member of the Team first needs to authorize it.

curtisy1 commented 3 months ago

Had to fix the theme support as well. On Linux, files and folders are case sensitive, so the added components folder broke the build because it was imported from Components (capital vs lower-case c)