search

kimmknight / rdpx

rdpx enables seamless remote access to applications running on another computer.
MIT License
71 stars 19 forks source link

Implement full Windows version/edition detection #4

Open kimmknight opened 3 years ago

kimmknight commented 3 years ago

Currently, you will be notified if the Windows edition detected is Home or Core.

This does not cover all incompatible Windows releases, such as Windows 7 or 8 Professional. I ignored these in the first instance because adding detection for Professional would exclude Windows 10 Professional (which is compatible). Compatibility list.

Need to implement detection of incompatible versions and editions in js/winver.js.

sashaqwert commented 3 years ago

If in the directory "C:\Program Files\RDP Wrapper" there is a file rdpwrap.ini containing the line "TerminalServices-RemoteConnectionManager-AllowAppServerMode=1", then the edition can be considered supported.

sashaqwert commented 3 years ago

Added info about "Windows 10 Enterprise for virtual desktops"

![изображение](https://user-images.githubusercontent.com/24974508/121671980-e6816e00-cab7-11eb-842c-00e9a25c2bce.png)

P.S: Don't ask me where I got the ISO ...

MrBrianGale commented 7 months ago

My opinion - I would link to the compat list on the home page and not worry about having the app check. Patches to Windows (SP's and KB's) could easily add or remove support. For example, XP SP3 added support for some things not available in SP2. Forget what offhand, but trying to maintain the compatibility in the app is a never ending battle. Using sashaquert's approach of the RDP Wrapper requires the end users to have that installed on their system, so it is not 100% reliable. I know I wouldn't bother installing RDP Wrapper on a Windows Server machine with enough user CALs to cover my use case... plus not sure what licensing I may violate by using that. Put it on the main page and if someone installs it on an incompatible OS, that's on them. POSSIBLY have a link during install to the compatibility list, but even that is overkill. I've installed tons of apps that are not compatible with my system in the past and it's my own dumb fault for not reading the docs first. I learned, so should end users of this tool. It is a sysadmin tool, not a "play" tool. Any sysadmin who can't read the docs shouldn't be installing the tool in the first place.

Just my 2 cents.