kimmobrunfeldt / spawn-default-shell

Spawn shell command with platform default shell
https://www.npmjs.com/package/spawn-default-shell
MIT License
12 stars 4 forks source link

Incorrect execute flag detection #1

Closed kimmobrunfeldt closed 8 years ago

kimmobrunfeldt commented 8 years ago

Detecting the shell execution flag should be based on the shell command, not based on platform. We should check if e.g. shell is cmd.exe -> use /c regardless of the platform.