[daemon] give priority to last=new keys

urjaman commented 9 years ago

instead of making unwanted repeat of old keys

I have a feeling that this is what people are confused by about repeat. On a normal keyboard when you press a second key you get the second key once, not a repeat of the 1st key. This also stops the autorepeat from starting while you're wondering why the 2nd key you're actually wanting to press didnt show up. In my usage this is not very noticeable change (I do feel it is better, but .. very slightly), i dont type this fast, but i think it'd be an improvement to others.

EDIT: Oh yeah this doesnt notice new keys if you do eg, a-down, b-down, a-up, c-down because then c will use the slot before b... A proper solution will need a state tracker (memory of last report).

Ape commented 9 years ago

Could you test if this fixes #11.

Ape commented 9 years ago

I tested this patch myself. It changes the behavior, but doesn't fix it.

With this patch it's like this:

Press down F => F is emitted as expected
Press down J => J is emitted as expected
Release F => another J is emitted (bug)
Release J => nothing happens as expected

urjaman commented 9 years ago

This (the one i meant originally) Effectively implemented, closing request.

kimmoli / tohkbd2

[daemon] give priority to last=new keys #14