search

kimoa / svg-edit

Automatically exported from code.google.com/p/svg-edit
MIT License
3 stars 0 forks source link

Icons fallback image not working in post-2.5.1 #926

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Remove any svg icons from images/svg_edit_icons.svg that contains a fallback 
like new_image

What is the expected output? What do you see instead?
Fallback png image is missing

Please use labels and text to provide additional information.
My guess is the jQuery 1.7 upgrade quietly broke svgicons plugin. Will look for 
the exact cause when I have time.

Original issue reported on code.google.com by asyazwan on 16 Mar 2012 at 11:01

GoogleCodeExporter commented 9 years ago 
Actually it doesn't work as I expect in 2.5.1. Previously it was probably 
cached SVG making me think it works.

How is this supposed to work anyway?

I assumed that when SVG image is not found, it will fallback to png image 
supplied as fallback object.

In the comment section of jquery.svgicons.js:
- 'fallback (object literal)': List of raster images with each
    key being the SVG icon ID to replace, and the value the image file name.

That sounds more like an "override" rather than "fallback"..?

In any case I'm not sure how it's supposed to work, and it's not working how I 
assumed it should. If SVG image is missing and fallback is present, it is not 
used. So icon become blank.

Any devs can chime in? Especially adeveria!

Original comment by asyazwan on 20 Mar 2012 at 3:27