kimpham54
commented
8 years ago - [x] 0. i. explain in more detail throughout the python section to transition frmo beginner/intermediate
- [x] ii.explain python what it's doing instead of cutting and pasting code
- [ ] iii. expand on geocoding issues. Adding the City column does
- [ ] iv. mostly fix the errors we get the first time we run the geocoder, but most of the time we can’t add this precise of a “helper”. What do we do if we’re running this on 500+ lines and it is wrong 15% of the time? Is there another step to clean the data? Or would you simply do it manually in Excel or using find replace in a text editor for all of the wrong locations?
- [ ] v. Leaflet disappointing. To address this concern, it would be great if you could add a section to the end on next steps. Suggesting we should try a time-based visualization is great, but where do we learn that? Is there a particularly good book on Leaflet that people could turn to and build on what they’ve learned here? Do we need to start by doing some more advanced Javascript tutorials?
- [ ] vi. kim: explain why this is better than google maps.
- [x] 1. The link for the original CSV downloads HTML from the Github page and not the correct raw data. Fix the link or add instructions to click through and download.
- [ ] 2. Generating points from the place names is one option and the right option for this exercise, but you might also want to mention the option to download or create polygons for this data. There are polygons for this particular dataset.
- [x] 3. (Note: programmers like to use "0" instead of "1" to indicate the first value in an index) – I’d say Python uses “0” instead of “1” to indicate the first value in an index.
- [x] 4. Typo: is where yu indicate
- [x] 5. There is not enough information here:
- [x] i. capabilities user-input static (Google's non-static geocoding service not in geopy)
- [x] ii. I’d expand or remove this line. The other lines are clear enough for an intermediate user.
- [x] 6. The data does not come with an underscore between Area and Name: “Area Name” not “Area_Name”. (see more on this below)
- [x] 7. Google Geocoder resulted the errors mentioned on the first try and I did not get it working.
- [x] i. I think you need to either expand on why humanists might want to use the Google tool or simplify the lesson focusing on the open tool and simply mentioning that users can experiment with other options on the own.
- [x] 8. It was not clear that we were continuing to build the function “main” as we added the geolocator and latitude/longitude steps. It would be better if the code blocks included the pervious code as it builds and shows the student how it expands.
- [x] 9. Option two is not clear. I don’t see how I’m meant to convert geocoding-output.csv into a vrt file? Are we meant to type this out by hand? You need to spell this out a little more clearly. Is there really not tool that will do this aside from the web tool that 99% of the people reading this tutorial will use?
- [x] 10. Clean up: {% include figure.html src="../images/webmap-02-countrycolumn.png" caption="Add a new Country column to your spreadsheet" %}
- [ ] 11. You suggest we add a column for Country and City and then just use the Country column, which still does not create usable results. Switching to City does work, though Outer London remains a problem. I’m guessing we’re not going to use inner, outer or greater London data, so maybe we should have deleted it from the start?
- [x] 12. Add a reminder to save census.geojson after you’ve fixed the data
- [ ] 13. Will the Simple server work from a Windows machine?
- [ ] i. Is this step needed if we’re working from a directory? Double clicking on mymap worked.
- [ ] 14. This would not be very helpful for someone who is stuck: Do you see a map now? Good! If not, you can troubleshoot by inspecting the browser, or by going back and retracing your steps.
- [ ] 15. My map at this point still includes Outer London in the Indian Ocean; maybe we could have deleted this earlier?
- [x] 16. Typo: each poit of data is represented by an icon
- [ ] 17. When creating the map we run into the same problem with “Area Name”; I’m guessing you made the change to the original CSV and forgot to add that step to the tutorial. I tried changing the leaflet code to remove the underscore, but not surprisingly, it breaks the map. I’m going to recreate my census.geojson file now with the underscore added, but the needs to be addressed at the start of the lesson. You might also delete inner, outer and greater London at that point?
- [ ] 18. Where is the stations.geojson data?