Closed mfeckie closed 4 years ago
I really like this PR!
@kimroen Do you have the bandwidth to review this PR. If not, what do you think about transferring over to adopted-ember-addons
?
@mfeckie Thank you so much for making this PR, and sorry for the radio silence.
@snewcomer I also like it - thanks for poking me about it!
Unfortunately, as we've talked about directly elsewhere I don't see myself having the capacity to look at this or my other ember projects now or in the near future.
I've invited you (@snewcomer) to become a collaborator on this project and ember-cli-document-title
, so if you can find the time and attention to give to these projects, please feel free to do so, and let's talk directly about access to publishing once there is something to publish.
Transferring over to adopted-ember-addons
also feels like a good idea.
Thanks again!
@kimroen Really really appreciate it! We are super grateful for these addons! If possible, could I get npm publish rights as well in the meantime? snewcomer
. We can explore the adopted addons, but only with your explicit permission!
@snewcomer Have updated PR to bring it to Ember 3.16. No other changes.
I'd be happy to see it merged, version bumped and released.
Also happy to become a maintainer should it become adopted.
@kimroen Really really appreciate it! We are super grateful for these addons! If possible, could I get npm publish rights as well in the meantime?
snewcomer
. We can explore the adopted addons, but only with your explicit permission!
@snewcomer You now have publish rights to both packages :)
@mfeckie Added to 1.0.0-beta.0
. Our app (as is all of them :)) is very large and we have some CSS tweaks to work out it looks like as I tested this. Other teams are verifying this so in the meantime put it in beta for a little bit until I get some feedback! Thanks again for everything.
This PR seems to have dropped compatibility with EmberCLI config/targets.js
was that intentional, or an oversight?
It was intentional to bring the library in line with how autoprefixer expects things to be.
In that case, it’s definitely worth adding a note in the changelog.
And maybe a readme item on how to achieve the old logic if possible.
I’d also wonder if you could reconsider?
It definitely breaks the principle of least surprise for me that an ember-cli addon based around browser support doesn’t automatically hook up the existing browser support config that ember-cli provides.
Happy to consider a PR with note for changelog and / or adding targets as an option again.
We did make the release a major to allow for breaking changes
ref #51 To add back support. Lmk what you think!
This PR
I noticed that the changleog suggests that broccoli-autoprefixer is already at
7
, but this isn't reflected inpackage.json
.