search

kimroen / ember-cli-autoprefixer

Automatically run your styles through autoprefixer
MIT License
103 stars 25 forks source link

missin semi-colon error when building apps with v1.0.0 #49

Closed fran-worley closed 4 years ago

fran-worley commented 4 years ago

I've had this in 3 apps. When updating from <1 to v1 I get a build error:

Build Error (broccoli-persistent-filter:Filter) in assets/dummy.css.map:1:788

/Projects/ember-light-table/assets/dummy.css.map:1:788: Missed semicolon>

You can recreate this in the dummy app for ember-light-table by bumping the autoprefixer addon. Any ideas?

snewcomer commented 4 years ago

Oh no! Did you create a PR @fran-worley? I had some problems but had to cleanup the world (rm -rf tmp dist node_modules and maybe other stuff) before it worked.

fran-worley commented 4 years ago

Thanks @snewcomer I've tried cleaning up and I still get the same issue. I've not raised a PR as if I'm honest I've no idea where to start! I guess it's possible that the issue is not here but in autoprefixer itself?

I had hopped this was a common issue! 😥

dknutsen commented 4 years ago

Just tried bumping to v1 and I'm seeing same thing

artemgurzhii commented 4 years ago

same here. NOTE: 0.8.1 works fine but bumping to the 1.0.0 fails, so if you see Missed semicolon error - try to rollback first, and if it doesn't work try different solutions

miguelcobain commented 4 years ago

Same thing happens here.

snewcomer commented 4 years ago

Has anybody gotten this to work? I had issues at the start, but if I recall, it was solved through cleanup. What Node are you on?

nag5000 commented 4 years ago

It seems https://github.com/kimroen/ember-cli-autoprefixer#note-on-using-with-ember-cli-sass fixes this error for me (I use ember-cli-sass).

snewcomer commented 4 years ago

For those that are curious, this is an example config for us after upgrading (was part of my commit to upgrade to 1.0.0)! Thank you @nag5000 for pointing this out!

    autoprefixer: {
        enabled: true,
        cascade: true,
        sourcemap: !envIsProduction
    },
    sassOptions: {
      sourceMapEmbed: !envIsProduction,
      implementation: sass,
      cacheInclude: [/\.(css|scss)$/]
    },

Let me know if this (or some other form) doesn't work for somebody!