search

kimroen / ember-cli-coffeescript

Adds precompilation of CoffeeScript files and all the basic generation types to the ember generate command.
MIT License
72 stars 49 forks source link

Remove blueprints for view and view-test #111

Closed mriska closed 7 years ago

mriska commented 8 years ago

They are removed in ember-cli as of 2.4.3 https://github.com/ember-cli/ember-cli/pull/5607 And having them in ember-cli-coffeescript gives errors if using a never version of ember-cli in the same project

Cannot find module 'ember-cli/blueprints/view'
Error: Cannot find module 'ember-cli/blueprints/view'
  at Function.Module._resolveFilename (module.js:339:15)
  at Function.Module._load (module.js:290:25)
  at Module.require (module.js:367:17)
  at require (internal/module.js:20:19)
  at Object.<anonymous> (/Users/mriska/work/test3/node_modules/ember-cli-coffeescript/blueprints/view/index.js:1:80)
kimroen commented 8 years ago

This isn't mergeable now because of some other changes, but I will make sure I merge it in manually before making another release. Thank you!

kimroen commented 7 years ago

The view-blueprints are actually still there, but they are moved to ember-cli/ember-cli-legacy-blueprints. Because of this, I am going to keep them in ember-cli-coffeescript for the time being. I'm releasing a new version today that fixes the current problem when trying to run them.

Thank you again very much for taking the time to make this PR, but I am going to close it now. Hopefully this makes sense.

mriska commented 7 years ago

No problem, thanks for fixing the issue when running them.