search

kimroen / ember-cli-coffeescript

Adds precompilation of CoffeeScript files and all the basic generation types to the ember generate command.
MIT License
72 stars 49 forks source link

project build freeze in v1.14.0 #112

Open matouskral opened 8 years ago

matouskral commented 8 years ago

With new version of ember-cli-coffeescript (1.14.0) when I rewrite route.js file into coffee and then I tried to build app, building process freezes or was in infinite loop. No error or another message it just keeps building. I tried that on new clean project on ember 2.4.2 just with ember-cli-coffescript installed. I switched to older version ember-cli-coffescript@1.13.2 and now it works pretty good. So I guess there is some bug in new version.

joankaradimov commented 8 years ago

I am experiencing the same issue on Windows. My colleagues are on Linux and they have no such problems.

kimroen commented 8 years ago

Hi, sorry about the trouble. It seems likely that this change is what made it stop working: https://github.com/kimroen/ember-cli-coffeescript/pull/104. If anyone wants to investigate this, I would appreciate that very much.

If @kralicek-m is also on Windows, then that's probably a good place to start looking.

matouskral commented 8 years ago

Yes, I had that issue also on windows 10.

JoelWAnna commented 8 years ago

this is caused by https://github.com/joliss/broccoli-coffee/commit/502d4319b54d5ab4bc1e582c3d60fe6d19dbe322#diff-168726dbe96b3ce427e7fedce31bb0bcR31

I submitted a workaround PR to broccoli-coffee https://github.com/joliss/broccoli-coffee/pull/16

The hang is a in mkdirp, because windows returns ENOENT when you have invalid characters in a path, causing mkdirp to go into an infinite loop

There is a PR pending from ages ago https://github.com/substack/node-mkdirp/pull/74/commits issues https://github.com/substack/node-mkdirp/issues/70 https://github.com/substack/node-mkdirp/issues/66