search

kimroen / ember-cli-coffeescript

Adds precompilation of CoffeeScript files and all the basic generation types to the ember generate command.
MIT License
72 stars 49 forks source link

Change addon exported files from .coffee to .js #136

Closed mriska closed 7 years ago

mriska commented 7 years ago

This PR changes the *-addon blueprints to use javascript files instead of coffeescript files. Without this change, addons using ember-cli-coffeecript creates files that can't be consumed in a application not using ember-cli-coffeescript.

Fixes #131

mriska commented 7 years ago

Same here, will fix to make tests pass.

mriska commented 7 years ago

@kimroen, pushed updated code with amended tests. Travis builds green now.

mriska commented 7 years ago

@kimroen, What do you think of this? Is it merge-worthy?

mriska commented 7 years ago

@kimroen the incorrect expectCoffee is now removed from the tests. I would suggest merging this now - I have created a new issue #140 for investigating if the addon blueprints can be removed completely. I'll be happy to take a look at that one separately.

kimroen commented 7 years ago

Great, thank you again!

perlun commented 7 years ago

Could we get a v1.16.1 with this fix included @kimroen? Pretty please with sugar on top. 😇

kimroen commented 7 years ago

Could we get a v1.16.1 with this fix included @kimroen? Pretty please with sugar on top. 😇

You absolutely could, but I'm in the middle of moving so I'm short on time. Hopefully soon!

kimroen commented 7 years ago

There we go! v1.16.1