Closed mriska closed 7 years ago
I didn't know there were node tests in here as well, I'll get those fixed.
@kimroen pushed updated code with amended tests. There is only one failure (beta) in Travis right now that looks like it needs poking to be rerun.
@kimroen, All builds are green now, do you think it should be merged, or are you still missing something?
This looks good - thanks again! 🎉
I noticed now that this missed some files, like the initializers.
@kimroen I'll check those out later today/tonight
@kimroen Created a new PR #139 that fixes initializer
blueprint.
This PR changes the blueprints from using a named variable to doing direct exports of the code. In addition to being more easy on the eyes, it fixes a problem with the compiled javascript file containing an undeclared variable in newer versions of the CoffeeScript compiler.
Fixes #135 Fixes #134
I have tested to create all of the blueprints changed:
And the tests pass with the exception of
view
which I assume is due to the fact that a fairly recent Ember version is used which no longer supportsview
s. I guess this blueprint can be removed at some point unless we want to keep it for people using it with older Ember version. On the other hand a case can be made for not helping them to create code that is deprecated in newer versions of Ember.