search

kimroen / ember-cli-coffeescript

Adds precompilation of CoffeeScript files and all the basic generation types to the ember generate command.
MIT License
72 stars 49 forks source link

Update to coffeescript 2 and ember-cli 3.0 #149

Closed jakesjews closed 3 years ago

jakesjews commented 6 years ago

Resolves #144

This should also resolve #112 since https://github.com/joliss/broccoli-coffee/issues/20 was resolved in the latest broccoli-coffee

jakesjews commented 6 years ago

Is there anything else that needs to be done to get this merged?

kimroen commented 6 years ago

@jakesjews Thank you so much for looking at this!

I was wondering: How do these changes affect compatibility? Could I still install ember-cli-coffeescript on my project using Ember 1.13 after this has been released?

Does this change required Node versions for the project?

I merged some changes, so there are some conflicts that need resolving - sorry about that.

jakesjews commented 6 years ago

@kimroen merged up now. Coffeescript 2.0 requires node version 6 or greater. I'm not quite sure if it works on ember 1.13 or not but I think it has reached EOL.

auvipy commented 6 years ago

you can definitely use the older versions with ember older versions by pinning the requirement. but 1.13 is EOL

mriska commented 6 years ago

It would be awesome to get this PR merged. I suggest making this version 2.0.0 of ember-cli-coffeescript, so updating would be a deliberate choice for existing projects.

boris-petrov commented 6 years ago

@kimroen - ping. :)

nudded commented 6 years ago

@kimroen re-ping, This has now become urgent as the new Ember testing API's use async everywhere

youroff commented 6 years ago

+1 and thanks, @jakesjews, great job! Hope it's merged soon, we also depend on coffeescript and use async api.

jakesjews commented 6 years ago

If anyone wants to use it I have published https://www.npmjs.com/package/eflex-ember-cli-coffeescript which uses coffeescript 2.0. The company I work for has been using it in production for a long time now.

youroff commented 6 years ago

That's awesome! We were using your branch in dev, but now that it's published as a separate package, will definitely switch to it.

kimroen commented 6 years ago

@jakesjews Would you be interested in helping maintain this package? The main reason I haven't done anything with this is that I have bigger plans for what I want to do with it, but I just never seem to find the time and energy for it.

jakesjews commented 6 years ago

@kimroen yeah I'm definitely willing to help

ovikholt commented 5 years ago

Any action here? :)