search

kimroen / ember-cli-coffeescript

Adds precompilation of CoffeeScript files and all the basic generation types to the ember generate command.
MIT License
72 stars 49 forks source link

Linting output in silent mode #52

Open kimroen opened 9 years ago

kimroen commented 9 years ago

ember-cli supports an argument, --silent, that should mute all output. This is useful for running tests and reading the output, for example.

ember-cli-coffeescript ignores this, and outputs the linting output either way.

kimroen commented 9 years ago

A few points on this:

  1. We should redo the linting-stuff to use the new linting interface available with ember-cli, which would make it a part of the test itself in this case.
  2. You could get around this at the moment by disabling linting in test-mode
  3. I don't think there is a way to check for the --silent-flag from ember-cli.
kimroen commented 8 years ago

ember-cli-qunit handles this here: https://github.com/ember-cli/ember-cli-qunit/blob/dccc61ce2b2ee25e6bef022b4a193811e0f6e280/index.js#L10

rwjblue commented 8 years ago

@kimroen - If the addon passes in ui or console object you can avoid needing to detect the --silent flag.

Basically, do this to allow console to be provided to the linter (and fallback if needed), then do this and this to pass that in.

kimroen commented 8 years ago

@rwjblue Thanks for the pointers, much appreciated!

If anyone wants to make a PR to fix this, I would really love that. If not, I'll get to it eventually. Maybe even before the issue is a year old! :blush:

olleolleolle commented 7 years ago

Looking at this issue, I note that the jshint parts have been extracted from the other addon:

https://github.com/ember-cli/ember-cli-qunit/pull/114/files