search

kimroen / ember-cli-coffeescript

Adds precompilation of CoffeeScript files and all the basic generation types to the ember generate command.
MIT License
72 stars 49 forks source link

Update test blueprints to reflect qunit 2.0 compatibility #54

Closed taddeimania closed 9 years ago

taddeimania commented 9 years ago

This commit should keep the blueprints up to date with recent changes in ember-cli meant to coincide with new qunit deprecations.

See commit here: https://github.com/ember-cli/ember-cli/commit/c35e35810b420f8a9df637db12ed4152c963aa62

This can probably wait until the next ember-cli version is released containing the new test blueprints.

kimroen commented 9 years ago

Thank you very much for doing this. I will hold off until ember-cli is updated, like you suggest.

:+1:

taddeimania commented 9 years ago

Updated commit to replace append to render.

taddeimania commented 9 years ago

rebased your master branch into this PR today to make it easier to merge.

taddeimania commented 9 years ago

Looks like CLI can't make up it's mind - i'll update the PR tonight to reflect this pending PR for cli.

https://github.com/rwjblue/ember-cli/commit/3d233a803b0ce17593ae3bc481477194ab846fa9

kimroen commented 9 years ago

Awesome :) Hopefully there's a new version of ember-cli soon.

taddeimania commented 9 years ago

This commit: https://github.com/taddeimania/ember-cli-coffeescript/commit/fd33db2bc151a0896f8e27b744aaa7aa8a82e87c removes QUnit globals from test blueprints to coincide with upcoming QUnit 0.2 compat changes.

See: https://github.com/rwjblue/ember-cli/commit/3d233a803b0ce17593ae3bc481477194ab846fa9

taddeimania commented 9 years ago

The new version of ember-cli was cut so this PR is relevant now! Go ahead and merge.

kimroen commented 9 years ago

Thank you very much!