search

kimroen / ember-cli-coffeescript

Adds precompilation of CoffeeScript files and all the basic generation types to the ember generate command.
MIT License
72 stars 49 forks source link

Use config hook for config #61

Open kimroen opened 9 years ago

kimroen commented 9 years ago

Use this: https://github.com/ember-cli/ember-cli/blob/master/ADDON_HOOKS.md#config

Instead of the home-made, free-range, organic implementation here: https://github.com/kimroen/ember-cli-coffeescript/blob/3d2d4091c45fe9622b4c7d38c085680c56757701/index.js#L16-L24

kimroen commented 9 years ago

The default implementation seems fine, so it should be enough to just make a file with the defaults and place it in /config.

kimroen commented 8 years ago

I haven't done this yet, because we don't have any tests, and I'm not confident I would catch all possible use cases of the config. Still not sure how to go about testing that.

kimroen commented 8 years ago

There's a related question here - at some point it was pretty clear that we were moving in the direction of having config in the config folder, but since the ember-cli-build.js file was introduced, it seems more fitting to have this kind of config in that file.

Not sure what to do about that.