search

kimroen / ember-cli-document-title

Adding document title behaviour to your ember app
MIT License
216 stars 61 forks source link

Fix example in README #33

Closed hell03610 closed 8 years ago

hell03610 commented 8 years ago

Example in README shows how to use the addon with nested routes.

Actual: If we follow the steps of the example we get "My Blog - Ember is Omakase - Posts" Expected: "Ember is Omakase - Posts - My Blog"

Solution Token array is filled internally with unshift, so in order to add the top level token for the whole app in the application route it should be done with unshift instead of push.

kimroen commented 8 years ago

You're totally right - nice catch! I'll update the tests to also use this same approach so I don't mess this up in the future.

Thanks!