search

kimroen / ember-cli-document-title

Adding document title behaviour to your ember app
MIT License
216 stars 61 forks source link

Updated fastboot compatibility #38

Open ronco opened 8 years ago

ronco commented 8 years ago

FastBoot is moving to a solution where the entire contents of <head> and <body> are injected into the document. In the near future title substitution will be removed entirely in favor of head substitution. This update switches the dependency on title substitution to use ember-cli-head for setting the title.

Following semver I've bumped the version since this change will require users to remove the existing <title> tag from their index.html. Suggestions for changes welcome.

/cc @tomdale @rwjblue

rwjblue commented 8 years ago

LGTM

rwjblue commented 8 years ago

@ronco - Can we warn folks if they forget to remove <title> from app/index.html? Or even do it for them in a blueprint?

ronco commented 8 years ago

@rwjblue I was thinking of maybe updating this to remove it in a browser only initializer since this delays the title until the app is loaded in a non-fastboot scenario (see this issue on ember-page-title).

But that doesn't solve a duplicate error when you are using it with FastBoot.

kimroen commented 8 years ago

I appreciate the help here. I'm a bit swamped, but wanted to let you know that I'm paying attention to this.

kimroen commented 8 years ago

I'm making a new release of ember-cli-document-title today, but it doesn't look like I'll have the time to include this, unfortunately. Soon!

I'd like to have tests for this, so I created a new issue for that: https://github.com/kimroen/ember-cli-document-title/issues/52. I might just test it manually locally first and release this change if it proves to take a long time to write these test.

Some things:

Thanks again, and sorry for the super-delay in getting around to checking this out.

gabrielcsapo commented 5 years ago

Is this going to get merged?