Doc how to write a simple title() with model info

kimroen / ember-cli-document-title

Adding document title behaviour to your ember app

MIT License

215 stars 61 forks source link

Doc how to write a simple title() with model info #39

Closed nruth closed 7 years ago

nruth commented 8 years ago

as it's not straightforward accessing the loaded model from inside the route.

I took this approach because the title function is given the tokens, not the model, as its argument.

If this isn't a good way to do it it'd be great to get another suggestion into the readme. Our particular use-case is that our API sets the expected page-title for some of our models.

kimroen commented 8 years ago

Hi, sorry for the late reply on this.

Is there a specific reason why you can't use the model passed in to the titleToken method for this? It's very possible I just don't understand your use case, but please let me know.

Thanks for taking the time to add this 👍

kimroen commented 7 years ago

I'm going to close this because I haven't heard back and without an answer I can't really tell if this is necessary or not. Please let me know if anything changes! ❤️