search

kimroen / ember-cli-document-title

Adding document title behaviour to your ember app
MIT License
215 stars 61 forks source link

Crash with Glimmer2 / Ember 2.9.0-alpha #46

Closed workmanw closed 8 years ago

workmanw commented 8 years ago

Here is the stack:

on-error.js:77 Error: Property set failed: object in path "_dom.document" could not be found or was destroyed.
    at setPath (ember.debug.js:19288)
    at Object.set (ember.debug.js:19208)
    at Class.setTitle (document-title.js:85)
    at Class.collectTitleTokens (document-title.js:65)
    at Object.triggerEvent (ember.debug.js:26166)
    at Object.trigger (ember.debug.js:53740)
    at Object.trigger (ember.debug.js:52451)
    at Class.send (ember.debug.js:25514)
    at Class.updateTitle (document-title.js:77)
    at Object.applyStr (ember.debug.js:20768)

I believe the problem is that container.lookup('renderer:-dom') has changed it's structure and no longer has _dom on it. See:

With Ember 2.7:

screen shot 2016-08-21 at 9 22 39 pm

With Ember 2.9.0-alpha:

screen shot 2016-08-21 at 9 23 16 pm

I'll see if I can figure out a solution and submit a PR.

awaer commented 8 years ago

@kimroen can you review this so the addon will be ready for 2.9 stable in the coming weeks?

kimroen commented 8 years ago

@awaer Will do - thanks for checking in. https://github.com/kimroen/ember-cli-document-title/pull/49#issuecomment-251322501

kimroen commented 8 years ago

This is now released in ember-cli-document-title@0.3.2 - thanks again 🎉

workmanw commented 8 years ago

Happy to help. 🎊

kratiahuja commented 8 years ago

This doesn't work with fastboot environment. I have a #53 that fixes this correctly.