search

kimroen / ember-cli-document-title

Adding document title behaviour to your ember app
MIT License
216 stars 61 forks source link

Added support for Glimmer 2. Fixes #46. #49

Closed workmanw closed 8 years ago

workmanw commented 8 years ago

This also improves the logic for the document.title = title fallback.

Fixes #46

asakusuma commented 8 years ago

@kimroen any reason not to merge this?

felixbuenemann commented 8 years ago

Works for me on ember v2.9.0-beta.1.

felixbuenemann commented 8 years ago

@kimroen Any chance of merging this fix and doing a new release?

workmanw commented 8 years ago

PSA: I'm sure this is common knowledge, but you can easily point your package.json to use this PR. This is what I've done in the interim until a new release is cut.

--  "ember-cli-document-title": "0.3.1",
++  "ember-cli-document-title": "kimroen/ember-cli-document-title#pull/49/head",

But certainly I'm 👍 merging and getting a new release out.

felixbuenemann commented 8 years ago

@workmanw Thanks, I didn't know about the short syntax, I'm currently referencing the source branch:

"ember-cli-document-title": "git+https://github.com/kategengler/ember-cli-document-title.git#glimmer2-support"
josemarluedke commented 8 years ago

I encountered this problem as well and this PR fixes it. Will this be landing soon?

bradleypriest commented 8 years ago

Thanks @workmanw

yankeeinlondon commented 8 years ago

any reason not to accept this PR?

workmanw commented 8 years ago

Ping: @kimroen. Shameless bump. Ember v2.9.0-beta.4 was just cut today. Any chance this PR can be merged and a new release can be cut before 2.9 ships?

kimroen commented 8 years ago

@workmanw Thanks for checking in. I'll absolutely do so.

I've been away for a bit, but I'm back and will get to it: https://twitter.com/kimroen/status/783060891944230912

Thanks for helping eachother out :heart:

workmanw commented 8 years ago

I've been away for a bit, but I'm back and will get to it.

@kimroen Hehe, I definitely know how that goes. Thanks!

kimroen commented 8 years ago

Travis is acting up, but I pulled down and ran everything locally to make sure. All good.

I'll take a look at the Fastboot-related PRs and see if it makes sense to add those or release this separately.

kimroen commented 8 years ago

Released in ember-cli-document-title@0.3.2 - thanks again 🎈