search

kimroen / ember-cli-document-title

Adding document title behaviour to your ember app
MIT License
215 stars 61 forks source link

Failing on 2.18 #68

Open chriskrycho opened 6 years ago

chriskrycho commented 6 years ago

With 2.17.2 and earlier, everything worked without issue.

Upon upgrading to 2.18.0, the title method never gets invoked.

mike183 commented 6 years ago

I'm using it with Ember / EmberCLI 2.18.0 without issue, albeit via prember/fastboot.

Not sure if you're also using ember-cli-head or not, but if so, upgrading from v0.3.x to v0.4.x did require some further changes, see here.

chriskrycho commented 6 years ago

Interesting. We're not using it directly, but ember-cli-meta-tags uses it, and there's an open PR over there for that upgrade, so I'll check and see if that's related.

kimroen commented 6 years ago

@chriskrycho Did you figure out if this was a problem in ember-cli-document-title directly?

chriskrycho commented 6 years ago

@kimroen I haven’t been back to it, in truth. Been super busy. Hoping to upgrade us in a week or two. I’ll let you know then what I see.

snewcomer commented 6 years ago

I put in a request to see if he could add me as a collaborator on ember-cli-meta-tags. Hasn't been much activity on those libs so hopefully we can get a response! ¯_(ツ)_/¯