Fix for "DEPRECATION: An addon is trying to access project.nodeModulesPath"

kimroen / ember-cli-document-title

Adding document title behaviour to your ember app

MIT License

215 stars 61 forks source link

Fix for "DEPRECATION: An addon is trying to access project.nodeModulesPath" #70

Closed tarponjargon closed 6 years ago

tarponjargon commented 6 years ago

Ran ember-cli-update on the addon

jrjohnson commented 6 years ago

@tarponjargon there are a lot of merge conflicts here that need to be resolved. The issue with nodeModulesPath is actually resolved in master already. So this PR may be unnecessary for what you are trying to accomplish.

kimroen commented 6 years ago

Thank you so much for taking the time to make a PR!

Unfortunately, like @jrjohnson is saying, this PR contains a lot of merge conflict markers, so it can't be merged as it is. In addition, the issue it's meant to fix has been resolved in the latest release of ember-cli-document-title: https://github.com/kimroen/ember-cli-document-title/releases/tag/v0.4.0

Because of this, I'm going to close this PR.