search

kimsama / Unity-QuickSheet

Unity-QuickSheet enables you to use spreadsheet file data within Unity editor.
http://kimsama.github.io/Unity-QuickSheet
MIT License
1.05k stars 190 forks source link

Change property drawers and gitignore #44

Closed JohannesDeml closed 6 years ago

JohannesDeml commented 7 years ago

Especially chaning the serialized propertie names from anme to display name makes everything more readable. The style also didn't look that good with the light skin.

Here is how it looks now:

grafik

kimsama commented 7 years ago

Hi, JohannesDeml

Great! Thank you for that all proceedings. I'll merge after review.

Thank you again.

JohannesDeml commented 7 years ago

Sure, no thing. I might have been a bit harsh with the enum drawer and the background (by just removing those). As for the background: It didn't look good with the light skin. As for the enum: I think it has to many fields. I didn't quite understand why you would want to expose so many.

Looking forward to your feedback :)

Btw. I really like the project and hopefully I will have time to implement a few more of my ideas how to make the tool more accessible and useful!

kimsama commented 6 years ago

I moved all example related files under Assets/QuickSheet/Example folder to make it easy to keep maintenance.

JohannesDeml commented 6 years ago

Nice, that sounds like a good idea!