search

kimsama / Unity-QuickSheet

Unity-QuickSheet enables you to use spreadsheet file data within Unity editor.
http://kimsama.github.io/Unity-QuickSheet
MIT License
1.05k stars 190 forks source link

Warning on Unity 2018 and above #72

Closed zzxiang closed 4 years ago

zzxiang commented 5 years ago

After imported the plugin into my project, a warning message always appears when I open my Unity Editor (version 2019):

There are menu items registered under Edit/Project Settings: QuickSheet/Select Excel Setting, QuickSheet/Select Google Data Setting Consider using [SettingsProvider] attribute to register in the Unified Settings Window.

UnityEditor.EditorApplication:Internal_CallUpdateFunctions()

Seems that since version 2018, Unity don't want us to put any menu items under "Edit/Project Settings" anymore. Therefore, I suggest to change

[MenuItem("Edit/Project Settings/QuickSheet/Select Google Data Setting")]

and

[MenuItem("Edit/Project Settings/QuickSheet/Select Excel Setting")]

to

[MenuItem("Edit/QuickSheet/Select Google Data Setting")]

and

[MenuItem("Edit/QuickSheet/Select Excel Setting")]
kimsama commented 5 years ago

Thanks for the reporting. Could you folk and pull request those changes?

zzxiang commented 5 years ago

Yes, PR is created.

kimsama commented 4 years ago

merged pull request. close the issue.