kimsible / peertube-plugin-social-sharing

Share a video or playlist URL on social media (Fediverse,Twitter..)
GNU Affero General Public License v3.0
7 stars 6 forks source link

Add gd translation #16

Closed gunchleoc closed 3 years ago

gunchleoc commented 3 years ago

Translation for Scottish Gaelic

BTW Enter's the instance's address should be Enter the instance's address

kimsible commented 3 years ago

Thanks for the addition ! You must add the file in package.json too, like this : https://github.com/kimsible/peertube-plugin-social-sharing/blob/b4504243d8aa60a9988343592160cf80a4013a02/package.json#L79

gunchleoc commented 3 years ago

Thanks for the addition ! You must add the file in package.json too, like this :

https://github.com/kimsible/peertube-plugin-social-sharing/blob/b4504243d8aa60a9988343592160cf80a4013a02/package.json#L79

Done. Sorted them alphabetically too - this will make management easier if you get a lot of languages in the future.

I hope I didn't mess up the ,, JSON is 0 tolerance on that...

kimsible commented 3 years ago

Thanks ! Are you sure the country code is not gd_GB ?

kimsible commented 3 years ago

BTW Enter's the instance's address should be Enter the instance's address

I will correct this just after merging.

gunchleoc commented 3 years ago

We usually don't add the country code & just use the generic locale for Gaelic. The chance that one could want to create e.g. a separate gd_CA translation is virtually nonexistent.

kimsible commented 3 years ago

Thanks for the details @gunchleoc ! don't hesitate to comment here if you see any issues with the new releases, the 0.9.1 adds the translation gd

gunchleoc commented 3 years ago

Thanks for the plugin!

I am not running a server, so it's hard for me to test without knowing who is using the plugin.