kimtore commented 6 years ago

This is an attempt to document and re-implement the internal storage of data, and I would like to open up for discussions around this matter.

codecov-io commented 6 years ago

Codecov Report

Merging #103 into master will decrease coverage by 0.45%. The diff coverage is 14.28%.

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   53.81%   53.35%   -0.46%     
==========================================
  Files          51       51              
  Lines        1797     1818      +21     
==========================================
+ Hits          967      970       +3     
- Misses        807      825      +18     
  Partials       23       23

Impacted Files	Coverage Δ
options/defaults.go	`0% <ø> (ø)`	:arrow_up:
commands/viewport.go	`45.88% <14.28%> (-10.37%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2d2e50...b6a6399. Read the comment docs.

tremby commented 6 years ago

I haven't gotten familiar enough with the codebase to be aware of any issues. Having said that, everything you're saying makes sense!

kimtore / pms

Refactoring the data model #103

Codecov Report