search

kimtore / pms

Practical Music Search is an interactive Vim-like console client for the Music Player Daemon.
https://ambientsound.github.io/pms/
MIT License
249 stars 23 forks source link

Add originaldate and originalyear fields #49

Closed tremby closed 7 years ago

tremby commented 7 years ago

This shouldn't be merged until Max merges https://github.com/MaxKellermann/libmpdclient/pull/1 and confirms it'll be part of libmpdclient 2.12 (and also my corresponding patch for MPD).

Just putting this here so it can be reviewed, for now.

tremby commented 7 years ago

My patches to MPD and libmpdclient have been merged. I've rebased this on master. Ready for review and merge!

tremby commented 7 years ago

Rebased again.

tremby commented 7 years ago

Unsure about the actual implementation. Does this field shadow the original date field?

It will sometimes exist and sometimes not, if that's what you mean. For sorting purposes I have originaldate falling back to the date field where necessary, but not for viewing purposes. I think this gives the best functionality in the cases I can think of.

Are anyone interested in seeing the re-issue year instead of the original year of release? If yes, then differing between these two fields as you have done here is a good choice. If no, it should be an option (set originaldate).

I personally want to see both. I have quite a few albums in their original release and also as a re-issue, and I want it to be obvious which is which, yet have them sorted right next to each other (even if other albums were released between the original and re-issue).

Does that answer your questions?