search

kimtore / pms

Practical Music Search is an interactive Vim-like console client for the Music Player Daemon.
https://ambientsound.github.io/pms/
MIT License
249 stars 23 forks source link

Add zb, zz, zt equivalents #98

Closed tremby closed 6 years ago

tremby commented 7 years ago

These commands move the viewport but leave the cursor in place. Respectively they move the viewport so that the cursor is at the bottom, in the centre, and at the top, and are called viewport high, middle, and low.

Closes #77

I've based this atop #96, since there's some overlap.

codecov-io commented 7 years ago

Codecov Report

Merging #98 into master will decrease coverage by 0.45%. The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   53.81%   53.35%   -0.46%     
==========================================
  Files          51       51              
  Lines        1797     1818      +21     
==========================================
+ Hits          967      970       +3     
- Misses        807      825      +18     
  Partials       23       23
Impacted Files Coverage Δ
options/defaults.go 0% <ø> (ø) :arrow_up:
commands/viewport.go 45.88% <14.28%> (-10.37%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ec43e6...bc4aa53. Read the comment docs.

kimtore commented 7 years ago

Needs rebase after #96 was merged.

tremby commented 6 years ago

Rebased.

kimtore commented 6 years ago

Forgot about this one. Needs rebasing against master before I can merge it.

tremby commented 6 years ago

Rebased.

kimtore commented 6 years ago

Very nice feature. Thanks!