kimxogus / react-native-version-check

A version checker for react-native applications
MIT License
713 stars 171 forks source link

Crashing at EXPO SDK 43 #149

Open nikopolidi opened 2 years ago

nikopolidi commented 2 years ago

Expo has deprecated unimodules and moved to 'expo' package; https://blog.expo.dev/expo-sdk-43-aa9b3c7d5541

unable to resolve
> 1 | import { NativeModulesProxy } from '@unimodules/core';

Migrating: https://github.com/expo/fyi/blob/master/expo-modules-migration.md

liorokach commented 2 years ago

Yes, with the migration from @unimodules now there is a problem.. Should be changed to import { NativeModulesProxy } from 'expo-modules-core'

victorglezcardoso commented 2 years ago

Yes, with the migration from @unimodules now there is a problem.. Should be changed to import { NativeModulesProxy } from 'expo-modules-core'

Is there a way of resolve this locally?

cristianFryla commented 2 years ago

@victorglezcardoso did you find a way to solved it locally as you asked? Tks!

FatmaMahmoud698 commented 2 years ago

I face the same issue did any one solve this ?

victorglezcardoso commented 2 years ago

cristianFryla No, unfortunately not. I make a walkaround controlling manually in the app the version of the store via a rest request to my server. When I update the app, I change in my server the version of the app and if it is necessary I force the app to update... Cheers.

cristianFryla commented 2 years ago

cristianFryla No, unfortunately not. I make a walkaround controlling manually in the app the version of the store via a rest request to my server. When I update the app, I change in my server the version of the app and if it is necessary I force the app to update... Cheers.

Ok, tks, I did the same unfortunaltely!!

rf1804 commented 2 years ago

I personally don't use expo, happy to have a pr if someone can

FatmaMahmoud698 commented 2 years ago

@rf1804 can you just upgrade the package used on folder related to the package react-native-version-check-expo

rf1804 commented 2 years ago

@rf1804 can you just upgrade the package used on folder related to the package react-native-version-check-expo

@FatmaMahmoud698 It was already done v3.4.3 was released 12 hours ago

https://www.npmjs.com/package/react-native-version-check-expo

FatmaMahmoud698 commented 2 years ago

@rf1804 on this path react-native-version-check/packages/react-native-version-check-expo/package.json there are still old versions

stri8ed commented 2 years ago

@FatmaMahmoud698

I created a fork, which does not depend on expo-localization.

https://www.npmjs.com/package/expo-react-native-version-checker