search

kin-labs / kinetic

MIT License
40 stars 24 forks source link

Figure out anything besides the happy path #120

Closed beeman closed 2 years ago

beeman commented 2 years ago

After doing some debugging in both Agora and Mogami main methods, here are some of the error messages we get. In general Agora mostly throws same message that Solana is throwing, so the implementation requires a catch validation in the Controllers and make sure it propagates Solana error. Some error messages will be changed in Mogami to make more sense

Below are some examples:

Method Reason Agora Error Message  Mogami Error Message  
createAccount   Authorize: blocked anonymous creations
getBalances PublicKey doesn't exist or Invalid PublicKey No Kin token accounts found 'accountId' must be a valid PublicKey   
requestAirdrop PublicKey doesn't exist or Invalid PublicKey NOT_FOUND  'accountId' must be a valid PublicKey  
submitPayment Insufficient funds. The transaction failed because of insufficient funds.  The transaction failed because of insufficient funds. (From Solana)  
beeman commented 2 years ago

@RamirezAlex this story should have some context in it before closing in #145

RamirezAlex commented 2 years ago

@beeman context added. please review and let me know if need to adjust something.

beeman commented 2 years ago

@beeman context added. please review and let me know if need to adjust something.

Thanks!