search

kinbiko / bugsnag

Well-documented, maintainable, idiomatic, opinionated, and *unofficial* rewrite of the Bugsnag Go notifier
MIT License
3 stars 0 forks source link

Strip build path from stacktrace filename #27

Closed kinbiko closed 2 years ago

kinbiko commented 4 years ago

Currently, the absolute path at which the binary was built is being reported. This doesn't work well with version control integrations. I don't see an obvious way to strip this data that's guaranteed to work, so best effort based on some analysis of filename and method name will have to do. Don't want to make users specify the source path, as this is a source of confusion. No pun intended.

kinbiko commented 3 years ago

Requesting that users build the binary with -trimpath if they want source code linking make things much easier.

-/Users/kinbiko/repos/bugsnag/examples/panics/main.go
+github.com/kinbiko/bugsnag/examples/panics/main.go
kinbiko commented 2 years ago

Would probably be best to get #47 done first, to verify the value of this bit of work. It can still be verified, but it requires some manual testing and messing around with curling requests to the Build API. Would be a lot faster to verify that it works continuously if we have a proven CLI for reporting info.