search

kind-work / two-fa

Two Factor Login for Statamic V3
https://statamic.com/marketplace/addons/2fa
Other
3 stars 5 forks source link

Translations do not get loaded #36

Closed motion-work closed 1 year ago

motion-work commented 1 year ago
Screenshot 2023-01-03 at 16 15 22

Just installed the package via composer and published the config but It seems that the translations won't get loaded? Did I forget something? My default Statamic language (app locale) is set to German, might this be the issue? Since there's no German translation file.

Statamic Version: 3.3.54

motion-work commented 1 year ago

Solved It. App locale is set to de. There is currently no way to "force load" the en version right?

motion-work commented 1 year ago

just created a Pull Request: https://github.com/kind-work/two-fa/pull/37

jcohlmeyer commented 1 year ago

Thank you for looking into this issue and creating a translation. I will look into it and merge your pull request.

motion-work commented 1 year ago

Hi @jcohlmeyer cool thanks! would it be possible to merge it and release a new version by the end of this week? otherwise we have to use our fork until then, since it's for our client 😬

jcohlmeyer commented 1 year ago

I do not think that I can get to it today. Sorry. I plan to get to it this weekend.

jcohlmeyer commented 1 year ago

Hey @motion-work I have added v2.0.0-beta.2 but am still not ready to push V2 because of some open issues with #30

motion-work commented 1 year ago

that's fine for now. thank you so much for taking the time!