Bug: isReturnToCurrentPage middleware setting

[gitdagray]

Prerequisites

• [X] I have searched the repository’s issues and Kinde community to ensure my issue isn’t a duplicate
• [X] I have checked the latest version of the library to replicate my issue
• [X] I have read the contributing guidelines
• [X] I agree to the terms within the code of conduct

Describe the issue

I'm using "@kinde-oss/kinde-auth-nextjs": "^2.3.3" and "next": "^14.2.3",

My middleware:

export default function middleware(req: NextRequest) {
  return withAuth(req, {
    isReturnToCurrentPage: true,
  });
}

Expected Behavior:

• Go directly to domain.com/books/scifi and get redirected to login ✅ Ok
• After logging in, get redirected back to domain.com/books/scifi ❌Fails

I can see the GET request go through with this URL: /api/auth/login?post_login_redirect_url=/books/scifi

But Next.js gives this error: ⨯ Error: URL is malformed "/books/scifi". Please use only absolute URLs

I can confirm that rolling back to "@kinde-oss/kinde-auth-nextjs": "^2.2.10", eliminates the issue.

It is possible that this merged PR https://github.com/kinde-oss/kinde-auth-nextjs/pull/173 is the issue.

Another post on your Discord on 6/12/24 with the same issue identified this PR and said, "I'm suspecting it's due to recently merged PR which switched to using NextResponse.redirect() but it's not calling it correctly (i.e. by feeding it / instead of instance of req.nextUrl.clone() et. al. )"

Library URL

https://github.com/kinde-oss/kinde-auth-nextjs

Library version

2.3.3

Operating system(s)

Windows

Operating system version(s)

Windows 10 Pro

Further environment details

No response

Reproducible test case URL

No response

Additional information

This likely impacts anything above 2.2.10

[tak0m0]

I am facing exactly the same problem. However, in my case, the problem still occurs in version 2.2.10. Explicitly setting isReturnToCurrentPage to false solves the problem, but it is not a fundamental solution.

[DanielRivers]

Hi @gitdagray and @tak0m0,

This has been fixed in https://github.com/kinde-oss/kinde-auth-nextjs/releases/tag/v2.3.5

[tak0m0]

Sounds good!!! thanks!!!