search

kinde-oss / kinde-auth-pkce-js

Kinde vanilla JavaScript authentication for SPAs using PKCE flows. Can be used with Vue / Angular or any JS framework
https://docs.kinde.com/developer-tools/sdks/frontend/javascript-sdk/
MIT License
17 stars 12 forks source link

chore: update prettier and format #65

Closed DanielRivers closed 6 months ago

DanielRivers commented 6 months ago

Explain your changes

Update prettier

Checklist

🛟 If you need help, consider asking for advice over in the Kinde community.

Summary by CodeRabbit

coderabbitai[bot] commented 6 months ago

Walkthrough

This update enhances security by enforcing that the redirect URI always matches, eliminating a previously optional check parameter. Additionally, it introduces a new configurable option within the Kinde client settings, allowing users to opt-in or out of this strict URI matching, thereby offering flexibility while maintaining robust security standards.

Changes

File Change Summary
CHANGELOG.md Updated to reflect the enforcement of redirect URI matching and the addition of an optional boolean flag in Kinde client options for this purpose.
Recent Review Details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 38608842dc197090394f6793972fe33e8daefb79 and cbb242f0b03fec2df3b3820b05396bbf7d4e34b1.
Files ignored due to path filters (2) * `package-lock.json` is excluded by `!**/package-lock.json`, `!**/*.json` * `package.json` is excluded by `!**/*.json`
Files selected for processing (1) * CHANGELOG.md (1 hunks)
Additional Context Used
LanguageTool (32)
CHANGELOG.md (32)
Near line 15: Possible spelling mistake found. Context: ...vember 2023 - feat: add proxy_redirect_uri for capcaitor apps [`#55`](https://gith... --- Near line 15: Possible spelling mistake found. Context: ...023 - feat: add proxy_redirect_uri for capcaitor apps [`#55`](https://github.com/kinde-o... --- Near line 39: Possible spelling mistake found. Context: ...3.0.24) > 26 October 2023 - Types for authUrlParams [`#51`](https://github.com/kinde-oss/ki... --- Near line 47: Possible spelling mistake found. Context: ...3) > 26 October 2023 - feat: add auth url params object [`#50`](https://github.co... --- Near line 47: Possible spelling mistake found. Context: ...> 26 October 2023 - feat: add auth url params object [`#50`](https://github.com/kinde... --- Near line 62: Possible spelling mistake found. Context: ...> 25 September 2023 - Enforce redirect uri match [`#48`](https://github.com/kinde-... --- Near line 63: Possible spelling mistake found. Context: ...e-js/pull/48) - Removing optional check param as it should always be matching [`be89a... --- Near line 65: Possible spelling mistake found. Context: ...0) - Added an optional enforce redirect uri match boolean to Kinde client options. ... --- Near line 65: Possible spelling mistake found. Context: ...l enforce redirect uri match boolean to Kinde client options. [`b8e88a5`](https://git... --- Near line 72: Possible spelling mistake found. Context: ...ce-js/pull/43) - added missing type for `isAuthenticated` method in `KindeClient` type [`#45`](h... --- Near line 72: Possible spelling mistake found. Context: ...ng type for `isAuthenticated` method in `KindeClient` type [`#45`](https://github.com/kinde-... --- Near line 74: Possible spelling mistake found. Context: ...7ce17fd419e8939a36db32cdee95) - updated eslint, lint-staged and prettier setup for typ... --- Near line 81: Possible spelling mistake found. Context: ... - fix: circular dependency reported by rollup at build time [`#40`](https://github.co... --- Near line 82: Possible spelling mistake found. Context: ...-pkce-js/pull/40) - Created and exposed `isAuthenticated` method from SDK [`#38`](https://github... --- Near line 83: If a new sentence starts here, add a space and start with an uppercase letter. Context: ...e-js/pull/38) - fix: suppressed console.error logs when running tests [`#37`](https:/... --- Near line 84: Possible spelling mistake found. Context: ...-pkce-js/pull/37) - created and exposed `isAuthenticated` method from SDK [`d12b64c`](https://gi... --- Near line 99: Possible spelling mistake found. Context: .../kinde-auth-pkce-js/pull/33) - bug: fix getUserProfile type definition [`#34`](https://github.... --- Near line 100: Possible spelling mistake found. Context: .../kinde-auth-pkce-js/pull/34) - bug: fix getUserProfile type definition [`#1`](https://github.c... --- Near line 126: An apostrophe may be missing. Context: ...ull/23) - test: add unit tests for core helpers [`051470a`](https://github.com/kinde-os... --- Near line 128: Possible spelling mistake found. Context: ...cef85047f060bb7bb011da7e0a92ae45218f) - cicd: add tests to release it [`edb4417`](ht... --- Near line 135: Possible spelling mistake found. Context: ...kinde-oss/kinde-auth-pkce-js/pull/22) - cicd with gh actions [`#21`](https://github.... --- Near line 135: Possible spelling mistake found. Context: ...kinde-auth-pkce-js/pull/22) - cicd with gh actions [`#21`](https://github.com/kind... --- Near line 141: Possible spelling mistake found. Context: ...-oss/kinde-auth-pkce-js/pull/15) - Bump minimist from 1.2.5 to 1.2.7 [`#13`](https://git... --- Near line 142: Possible spelling mistake. ‘licence’ is British English. Context: ...s/kinde-auth-pkce-js/pull/13) - Add MIT licence [`#12`](https://github.com/kinde-oss/ki... --- Near line 147: Possible spelling mistake found. Context: .../kinde-oss/kinde-auth-pkce-js/pull/8) - ci: add release it [`232393f`](https://git... --- Near line 148: Possible spelling mistake found. Context: ...c3250cdd1b60f10a23ed67460e22a) - update rollup and make types public [`775148a`](https... --- Near line 149: Possible spelling mistake found. Context: ...e92cea8454d957918f2c52e086dc6475) - add appstate and audience [`00eac43`](https://github... --- Near line 156: This abbreviation for “identification” is spelled all-uppercase. Context: ...inde-auth-pkce-js/pull/6) - include org id [`#5`](https://github.com/kinde-oss/kin... --- Near line 158: The abbreviation for “identification” is spelled all-uppercase, or did you mean “I’d” (= I would/had)? Context: ...f6d8504) - options include organization id [`1491632`](https://github.com/kinde-os... --- Near line 165: This phrase is duplicated. You should probably use “logout endpoint” only once. Context: ...0.5...v0.0.6) > 21 April 2022 - Peter/logout endpoint [`#4`](https://github.com/kinde-oss/kinde-auth-pkce-js/pull/4) - logout endpoint [`06e8cba`](https://github.com/kinde-os... --- Near line 173: There seems to be a noun/verb agreement error. Did you mean “includes” or “included”? Context: .../kinde-oss/kinde-auth-pkce-js/pull/3) - include logout uri [`#2`](https://github.com/ki... --- Near line 173: Possible spelling mistake found. Context: ...e-auth-pkce-js/pull/3) - include logout uri [`#2`](https://github.com/kinde-oss/kin...
Additional comments not posted (1)
CHANGELOG.md (1)
`62-65`: The changelog entries for version 3.0.21 are clear and well-documented. The links to the pull requests and commits provide easy access to more detailed information.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.