kindlyops / havengrc

โ˜๏ธHaven GRC - easier governance, risk, and compliance ๐Ÿ‘จโ€โš•๏ธ๐Ÿ‘ฎโ€โ™€๏ธ๐Ÿฆธโ€โ™€๏ธ๐Ÿ•ต๏ธโ€โ™€๏ธ๐Ÿ‘ฉโ€๐Ÿ”ฌ
https://www.havengrc.com
Apache License 2.0
97 stars 21 forks source link

Refactor data model for survey to allow more flexible reporting and presentation #567

Closed crashGoBoom closed 5 years ago

crashGoBoom commented 5 years ago

It will now keep track of what type of survey in the survey_responses table.

Issues #HAV-309,HAV-326

Signed-off-by: Christopher Mundus chris@kindlyops.com

Discussion list or pending tasks

statik commented 5 years ago

Hoisting this test failure to look at later from apitest

  Scenario: Get latest dashboard info                                    # features/sqitch-jwt.feature:10
    When I send a GET request to "http://{buffalo_server}/api/dashboard" # cucumber-api-0.7/lib/cucumber-api/steps.rb:103
    Then the response status should be "200"                             # cucumber-api-0.7/lib/cucumber-api/steps.rb:135
      Expect 200 but was 500 (RuntimeError)
crashGoBoom commented 5 years ago

@statik I think in order to fully test this new dashboard api we will need a cucumber test for posting survey results to api/surveys which in turn will require faktory to be implemented in the test suite as well. I think that is out of scope for this PR but let me know what you think. What this PR is missing now is the Visualization on the dashboard. I think that might be worth separate PR at this point? Let me know what you think. Thanks!