Reduce logging noise

[armiller]

The info logging for rsync adds a lot of noise to a test kitchen run. Would it be possible to switch that info output to debug or make it optional to display?

[i11]

Hi,

That should be possible. Could you please post a small snippet of the log output you would like to get removed?

[vills]

+1 here

Think, @armiller talking about this:

       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/cache to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/cache: 1.89 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/client.rb to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/client.rb: 1.75 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/cookbooks to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/cookbooks: 7.82 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/data_bags to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/data_bags: 2.17 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/dna.json to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/dna.json: 1.72 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/environments to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/environments: 1.70 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/nodes to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/nodes: 1.66 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/roles to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/roles: 1.88 sec
       [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/validation.pem to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/validation.pem: 1.79 sec

Sure, there is no need at least in in this info in each line: <{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}> (in case of -l info of course).

[i11]

Would you like for [RSYNC] Time taken to upload... messages to go away as a whole on info level or should it be truncated to something like [RSYNC] Time taken to upload /my/local/path/suites to /tmp/verifier/suites?

[vills]

In my opinion, as test-kitchen output logs like Preparing data_bags, transport-rsync should also output info about transfers, in way:

• debug: [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/cache to user@192.168.15.10<{:user_known_hosts_file=>"/dev/null", :paranoid=>false, :port=>22, :compression=>true, :compression_level=>6, :keepalive=>true, :keepalive_interval=>60, :timeout=>15, :keys_only=>true, :keys=>["/path/to/my/keyfile"], :auth_methods=>["publickey"], :user=>"user"}>:/tmp/kitchen/cache: 1.89 sec
• info: [RSYNC] Time taken to upload /var/folders/7l/zfjgk97s69q6ylcmdlzw22s00000gn/T/default-ubuntu1404-chef11-sandbox-20151104-32518-1r5fser/cache to user@192.168.15.10:/tmp/kitchen/cache: 1.89 sec
• warn: nothing

But, looks like @armiller want completely hide such logs in info level.

[armiller]

Ideally the rsync transport should mimic the default ssh transport where there are no additional messages during the transfer of files (other than the default transferring-files to ...). I think the [RSYNC] Time taken to upload... messages are more useful for debugging. So as a whole I think switching https://github.com/unibet/kitchen-transport-rsync/blob/master/lib/kitchen/transport/rsync.rb#L47 to debug would fix the nosiy output while still giving the user the option to view the information. Thoughts?

[i11]

@armiller sounds reasonable to me.

[i11]

0.1.2 released. Please let me know if there is anything more you would like to be changed.

[armiller]

@i11++. Thanks for the quick response!

[vills]

@i11 thanks!