search

kindredgroup / kitchen-transport-rsync

Test Kitchen transport Rsync
Apache License 2.0
12 stars 7 forks source link

loosen version constraints on test-kitchen #7

Open robuye opened 4 years ago

robuye commented 4 years ago

Hi @i11 :wave:

Is it okay to loosen test-kitchen version constraint? It still works like a champ on 2.3.3 & I'm using it alongside kitchen-docker & kitchen-inspec.

I also removed version.rb file and hardcoded the version as a string in gemspec to avoid loading issues when Bundler requires it before Kitchen gets to.

arthurzenika commented 4 years ago

+1

jamesdehart commented 4 years ago

@i11 Could we get this merged? I would love to use this with newer version of TestKitchen.

i11 commented 4 years ago

@jamesdehart I really I wish I could, but I don't have the merging rights anymore and it doesn't seem like anyone else from the company cares enough. I'm sorry it got to this point. Please feel free to fork the project and publish it under a different name. At least you will be able to maintain it in that way.

jamesdehart commented 4 years ago

To: @robuye CC: @arthurlogilab @i11

I have copied the source for this project and this PR and moved it to https://github.com/skillfox/kitchen-transport-rsync/pull/2 where my buddy and I will start to maintain and update this gem. Our plan is to reach out to the owners of this github org and ask if we could take it over. We would love anyone that wants to help to help contribute.

Thank you for creating this gem. I have used it for years and I'm so glad to keep it alive.

robuye commented 4 years ago

It's such a nice gem and worked very well for me too. I'm glad to see it will be maintained. @i11 thanks for creating it and @jamesdehart for picking it up from here.

I will keep the P/R open for now so if someone comes here looking for this fix they will know where to find it.

unicolet commented 3 years ago

with @jamesdehart clone gone ( https://github.com/skillfox/kitchen-transport-rsync gives a 404 ) there's not workaround for this problem anymore :-( Any chance this PR could get merged? Thanks in advance :-)

robuye commented 3 years ago

I pushed one more commit to relax constraints so they fit their dependencies versioning strategy better. And some embarrassing typos. I saw it added on @jamesdehart clone. Feel free to use my fork if you like, I will keep it around.