search

kindredgroup / puppet-forge-server

Private Puppet forge server supports local files and both v1 and v3 API proxies
69 stars 44 forks source link

Add S3 backend. #29

Open taik0 opened 8 years ago

taik0 commented 8 years ago

Added an S3 backend. I Dockerized the service and added the ability of using the options with environmentals to make it easier to use in docker.

i11 commented 8 years ago

Nice!!! Let me have a closer look...

i11 commented 8 years ago

Sorry for the delay, I was a bit absorbed by other errands.

First of all thanks for the great input! I was wondering whether you could divide this PR into several ones, for better visibility. For example docker related changes, option parsing and s3 backend. Maybe even a fourth one for minor changes like line 33 in lib/puppet_forge_server/api/v3/releases.rb, as there some complications to that change.

It would be great if you could include a few unit tests stressing new methods and maybe even old ones if there are behavioural changes.

Minor improvements to reduce code duplication in S3 and for example Directory classes could be made as well, but that's a minor thing and I could take care of it later on.